Prevent import * into index.js file so that bundlers can treeshake efficiently.#2588
Open
Jme797 wants to merge 1 commit intovalidatorjs:masterfrom
Open
Prevent import * into index.js file so that bundlers can treeshake efficiently.#2588Jme797 wants to merge 1 commit intovalidatorjs:masterfrom
Jme797 wants to merge 1 commit intovalidatorjs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2588 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 115 +1
Lines 2536 2535 -1
Branches 642 643 +1
=========================================
- Hits 2536 2535 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Jme797
force-pushed
the
2587-codesplitting
branch
from
3db8c9a to
4f4f0d1
Compare
Jme797
force-pushed
the
2587-codesplitting
branch
from
4f4f0d1 to
de9b0c7
Compare
Member
|
@Jme797 I'm noticing the test failures in other PRs as well. I think it's a dependency issue, will look into it later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2587
Modifies the exports inside index.js so that instead of importing all the code into the file and exporting it as a single object it just exports the functions directly.
This comes with the caveat you can no longer import * like
import validator from 'validator'inesmmodules because that prevents codesplitting.If you really want to for whatever reason you can replace that syntax with
import * as validator from 'validator'Though importing specific functions is more efficient using imports like
import {isEmail} from 'validator'Checklist